Randell Jesup
Randell Jesup
The tests also test that move() can overwrite an existing file. This is mentioned nowhere in the spec, and the spec says "Attempt to move entry to destination in the...
Also file.move(dir, "") should fail, per the spec; the wpt tests assume it's the same as file.move(dir)
> > Also file.move(dir, "") should fail, per the spec; the wpt tests assume it's the same as file.move(dir) > > Good catch. We should probably update the WPTs and...
Attempts to move a directory to within itself should fail. Attempts to move the root directory should fail... at least in OPFS, but that would be handled by the above...
The wpt tests check that moving a file to the same name succeeds (I.e. succeeds in doing nothing). (They don't check if moving a directory to the same name succeeds,...
I wonder if the fact that move-that-doesn't-move succeeds in chrome is related to the fact that it currently silently allows a move() to overwrite a file. At this moment, we...
Also don't forget we could have handles in both MainThread and in workers to the same object, and delete it from either
removeEntry() does not (in the spec currently) take a shared lock on the object being removed. Whether it takes a lock in Chrome at the moment isn't the question. We...
I'm going to assume we should take an exclusive lock, and if that fails return InvalidModification
Re TPAC discussion about deleting/moving files with handles: What are FileHandles/DirectoryHandles? If you argue they are abstract paths, then deleting the underlying file/directory would cause an error if we try...