lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Interactive Rebase sometimes hangs

Open jesseduffield opened this issue 6 years ago • 1 comments

Describe the bug I'm not sure why it happens but sometimes an interactive rebase will simply hang. Most recent example is when squashing 8 commits in a row, with the parent commit being a merge commit.

Expected behavior If there is a prompt that requires user input, we should switch to that subprocess.

Desktop (please complete the following information):

  • OS: OXS
  • Lazygit Version v0.8 (but it probably still happens on later versions)

Additional context Really want to make this interactive rebase thing robust so that people feel safe using it.

jesseduffield avatar Nov 12 '19 04:11 jesseduffield

I don't know if this is the same as OP, but I found a similar issue during patch creation where, if I try to move some changes into a new commit, during the intermediate steps of rebasing, the pre-commit hooks run, and one of my hooks would wait for user input (gitlint). This would make lazygit hang and the only way to recover is to killall lazygit, and then recover the previous state.

I found an issue open for gitlint not working in non-interactive environments: https://github.com/jorisroovers/gitlint/issues/171

However, it would be a cool feature for lazygit to give back control to the user when a hook requires interaction from the user, or to just ignore hooks entirely (based on some flag in the config file).

Possibly a duplicate of: https://github.com/jesseduffield/lazygit/issues/3557

PysKa-Ratzinger avatar Oct 12 '24 15:10 PysKa-Ratzinger