lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Submit and Review PRs

Open mchisolm0 opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. No, just would love not having to leave Lazygit. 😊

Describe the solution you'd like I would like a method of reviewing and submitting PRs similar to the GitHub PR extension from Microsoft (link: https://github.com/microsoft/vscode-pull-request-github).

Describe alternatives you've considered

  • Using the web interface
  • Using GitHub desktop
  • Using the VSCode extension (link again: https://github.com/microsoft/vscode-pull-request-github)
  • Using GitHub CLI
  • Using Graphite CLI (link: https://graphite.dev/)
    • Note: Graphite doesn't really solve the issue because you can only create PRs, but being compatible with their stacked PRs would be nice if possible.

Additional context I would like being able to do the following without leaving Lazygit:

  • View a list of pending PRs
  • Select a PR to review
  • See the details of the PR (view diffs and any comments)
  • Add general and/or line specific comments
  • See reviewers needed and how many have reviewed
  • See test status
  • Create a PR

Possible steps:

  • [ ] Setup GitHub auth
  • [ ] Design rough layout (start with Lazygit layout
  • [ ] Retrieve and display list of PRs
  • [ ] Design rough PR details (diffs, general comments, button to approve)

Happy to help with this, but I realize it may not make since in Lazygit.

mchisolm0 avatar Jun 05 '24 12:06 mchisolm0

I don't think I made clear in the issue, so I wanted to here. I know this would be a lot, so I would love to build this out myself (never used Go before like the template mentioned).

My main question is, does this make sense in the context of Lazygit? I could see it needing to be a separate project due to the complexity.

mchisolm0 avatar Jun 05 '24 12:06 mchisolm0

there is also gh-dash https://github.com/dlvhdr/gh-dash which can do this. you can also combine it with lazygit and neovim

carmen-gh avatar Jun 11 '24 08:06 carmen-gh

This!

I am switching from VsCode to nvim and lazygit.

The Github Pull Request plugins in VsCode is so great, I wish this comes to LazyGit!

mathieurousseau avatar Aug 19 '24 18:08 mathieurousseau

As someone who's desperately looking for a way to review massive PRs that no extant Git integration is happy dealing with, would absolutely welcome this!

Perksey avatar Jan 11 '25 15:01 Perksey

Hey @mathieurousseau and @Perksey, I will say that I have been using gh-dash that carmen-gh suggested and really liked it so far. Maybe you can try that? It is an extension of the GitHub CLI. The link to the project is https://github.com/dlvhdr/gh-dash

mchisolm0 avatar Jan 16 '25 04:01 mchisolm0