lazygit icon indicating copy to clipboard operation
lazygit copied to clipboard

Bring back y to confirm dialogs

Open J053Fabi0 opened this issue 2 years ago • 5 comments

Topic Some releases ago the option to confirm dialogs with y was removed and I think it should come back.

Your thoughts This issue is to raise awareness to the problem and see how many people upvote it, meaning they agree with me. While the enter key is a fairly universal way of confirming something, the y key is also widely spread.

Right now there's no way to enable the use of y. The following configuration mucks up the input windows

keybinding:
  universal:
    confirm: 'y'

and something like this one is not possible

keybinding:
  universal:
    confirm: ['enter' ,'y']

J053Fabi0 avatar May 08 '23 23:05 J053Fabi0

I confirm this issue. Enter as not an universal "Agree", because often default button is "No" and Enter confirms it.

Vanav avatar May 11 '23 11:05 Vanav

because often default button is "No"

In lazygit or in unixoids in general?

mark2185 avatar May 11 '23 11:05 mark2185

because often default button is "No"

In lazygit or in unixoids in general?

In interfaces in general, including Unix. I think that Enter as "yes" is not obvious. Example:

rm -i test

rm: remove regular empty file 'test'?

Enter will mean "No" here.

Vanav avatar May 11 '23 11:05 Vanav

I agree, I found the change very confusing, and not being able to use 'y' as a positive confirmation feels very counter intuitive. At least allow either 'enter' or 'y'.

pumbers avatar Jul 18 '23 15:07 pumbers

Not having y and n as options is confusing. It would be nice to have both as an option. This gets a +1 from me.

scottchiefbaker avatar Apr 10 '24 15:04 scottchiefbaker