jesseduffield
Highlighting broken with non-standard bright terminal colors
Describe the bug
#1656 made the selected line "bright". But it is not safe to assume that the "bright" colors are actually brighter versions of the base colors. This is not an actual standard and some color schemes may use the "bright colors" for entirely different colors, which makes the hightlighting in lazygit broken.
Expected behavior
An option to make the selected line not bright (off by default) would solve the issue.
I'm wondering if we should make the new logic opt-in rather than opt-out given the issues I've seen recently. Hard to get a grasp on what's a more common situation though
I was just looking into this, and it seems that having the "bright" colors as actual bright colors (so not what I have) is certainly more common. So the new behavior seems reasonable, and I'd say opt-out is fine. (I got used to sometimes having to tweak colors in terminal apps due to the uncommon setup.)
A switch to opt-out of bright colors would be very useful for those of us running unusual terminal themes.
This is +1 on my wanted list.
