Jesse Duffield
Jesse Duffield
Ah, that makes sense, thanks
> In many cases, SNS already supports this queuing and fanout functionality, including retries, filtering and dead-letter queue handling. I no longer suggest adding SQS as an async source, or...
@isti115 I've just had a look through the code: This is great work, I'm happy to merge it. You just need to fix that lint issue (looks like a code...
I've taken the liberty of making those changes myself as I'm itching to get this release out today!
That sounds quite do-able. I'll chuck a good-first-issue label on this. The presentation folder is where all that stuff is handled and we could pass a config struct in saying...
@sergey-suslov nice work! I've just pulled your code and gave it a test and it works great. Which info will be available: anything on the commit model i.e. `pkg/commands/models/commit.go`, but...
Hey @afhoffman are you still interested in continuing with this PR?
Happy to wait on others to see their perspectives before giving my 2c
The main reason I don't want to make force pushes disabled by default is because anybody who uses rebasing as part of their daily workflow needs to frequently force push....
I like the idea of a popup that appears once which allows the user to set the config value from the popup