jerryscript icon indicating copy to clipboard operation
jerryscript copied to clipboard
verified publisher icon jerryscript-project

Fix the private field crash for the Array object.

Open paintedveil5 opened this issue 1 year ago • 3 comments

Fix the private field crash in the Array object mentioned in https://github.com/jerryscript-project/jerryscript/issues/5138

paintedveil5 avatar Apr 20 '24 08:04 paintedveil5

Good patch. Please add the testcase.

zherczeg avatar May 03 '24 09:05 zherczeg

Good patch. Please add the testcase.

Added.

paintedveil5 avatar May 03 '24 15:05 paintedveil5

Please squash the commits and add DCO to the commit message.

zherczeg avatar May 04 '24 04:05 zherczeg

@akosthekiss Please review the latest changes.

LaszloLango avatar Nov 12 '24 12:11 LaszloLango

We should check whether this fixes #5097 and #5100

LaszloLango avatar Nov 22 '24 10:11 LaszloLango

I've updated the test cases and rebased to the master. This PR fixes #5097 and #5100 and #5138 as well.

robertsipka avatar Nov 25 '24 07:11 robertsipka

@robertsipka could you please add new regression tests with the issue numbers for all three?

LaszloLango avatar Nov 25 '24 08:11 LaszloLango

@robertsipka could you please add new regression tests with the issue numbers for all three?

I've followed the author's original intention and amended the other two test cases to the test case which was originally included in the PR, but It's actually easier to follow if they are added as regression tests, I modified it.

robertsipka avatar Nov 25 '24 08:11 robertsipka