jerryscript icon indicating copy to clipboard operation
jerryscript copied to clipboard

Fixes nuttx target warning

Open lygstate opened this issue 3 years ago • 2 comments

jerry-main.c: In function 'str_to_uint':
jerry-main.c:89:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   89 |     *out_p = num_str_p;
make[4]: Leaving directory '/home/runner/work/jerryscript/jerryscript/targets/os/nuttx'
make[3]: Leaving directory '/home/runner/work/jerryscript/apps'

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo [email protected]

lygstate avatar Feb 10 '22 09:02 lygstate

Good catch! I think, it's better to remove that parameter since str_to_num is used only once at jerry-main.c:179 with NULL argument for out_p.

rtakacs avatar Feb 22 '22 11:02 rtakacs

LGTM (informal)

rtakacs avatar Mar 02 '22 12:03 rtakacs