github-pr-coverage-status-plugin icon indicating copy to clipboard operation
github-pr-coverage-status-plugin copied to clipboard

#42 #35 #28 set/get master coverage by repo URL instead of PR URL

Open terma opened this issue 8 years ago • 10 comments

terma avatar Oct 12 '17 04:10 terma

are there any plans to get this fix merged ?

ayoub-benali avatar Jan 26 '18 16:01 ayoub-benali

Please merge the changes as it solves the problem which we are facing for long.

AASyedAbbas avatar Mar 16 '18 16:03 AASyedAbbas

@terma it'll be great if you can merge this and make a new release soon.

rohitjha avatar Apr 05 '18 18:04 rohitjha

When is this getting merged?

gouraharidas avatar May 21 '18 20:05 gouraharidas

@terma Any plan for the merge?

killthemyth avatar Jul 07 '18 11:07 killthemyth

Will this get merged?

mahyarv avatar Jan 16 '19 17:01 mahyarv

@mahyarv let me re-test it, and I will merge it

terma avatar Jan 18 '19 06:01 terma

For me this is still not the correct way to store the master coverage. As soon as you have multiple projects within one repository it always compares to the project that has the latest build.

Proposal: Use: $GIT_REPOSITORY/$PATH_TO_PROJECT/$PATH_TO_COVERAGE_REPORTS Alternative: $GIT_REPOSITORY/$CONFIGURABLE_PROJECT_NAME

On the screenshot below one pull request is affecting multiple of our projects in the same repository. When opening the pull request multiple projects in Jenkins start to build. As you can see the reference is always 62% (which is the coverage from the last project that built on master) image

I am willing to contribute with a pull request to this issue, but this pull request has been open 1,5 years now. Will my contribution ever be merged?

adiesner avatar Mar 25 '19 12:03 adiesner

@adiesner yep, feel free, I will review it

dmotpan avatar Mar 25 '19 13:03 dmotpan

@terma @dmotpan Is the maintenance of this plugin still active, because I was planning to develop an extension point to this to use in the Github Checks API Integration for jenkins

sladyn98 avatar Apr 03 '20 18:04 sladyn98