fix: always show the GitHub endpoint selection

Open carlossg opened this issue 4 years ago • 4 comments

Description

so users are aware that they must add a new endpoint in configiuration

Standardize the docs for apiUri

Submitter checklist

[ ] Link to JIRA ticket in description, if appropriate.
[x] Change is code complete and matches issue description
[ ] Automated tests have been added to exercise the changes
[ ] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

[ ] Run the changes and verify that the change matches the issue description
[ ] Reviewed the code
[ ] Verified that the appropriate tests have been written or valid explanation given

Documentation changes

[ ] Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

Mar 07 '21 11:03 carlossg

I checked the source and app credential rendering, but not sure in what page is GitHubSCMNavigator used?

Mar 07 '21 11:03 carlossg

@carlossg Ping?

Apr 19 '21 19:04 bitwiseman

Today if you add a new GitHub App credential there is no option to select a GitHub enterprise installation. You must know that you need to go to settings - manage jenkins and add the endpoint. This makes it explicit, it shows the github.com endpoint and in the help it tells you how to add a new endpoint, so it saves time to new users

Apr 20 '21 08:04 carlossg

before:

after:

Dec 27 '23 14:12 carlossg