github-branch-source-plugin icon indicating copy to clipboard operation
github-branch-source-plugin copied to clipboard

JENKINS-64662 Create GitHub App Credentials Binding to support owner override

Open nrayapati opened this issue 5 years ago • 10 comments

Description

Create GitHub App Credentials Binding to support owner override See JENKINS-64662 for further information.

Submitter checklist

  • [X] Link to JIRA ticket in description, if appropriate.
  • [X] Change is code complete and matches issue description
  • [x] Automated tests have been added to exercise the changes
  • [x] Reviewer's manual test instructions provided in PR description. See Reviewer's first task below.

Reviewer checklist

  • [ ] Run the changes and verify that the change matches the issue description
  • [ ] Reviewed the code
  • [ ] Verified that the appropriate tests have been written or valid explanation given

Documentation changes

  • [x] Link to jenkins.io PR, or an explanation for why no doc changes are needed

Users/aliases to notify

@bitwiseman @timja

Testing Results

Screen Shot 2021-01-22 at 8 47 08 PM

nrayapati avatar Jan 23 '21 02:01 nrayapati

@bitwiseman @timja thoughts on this change?

nrayapati avatar Jan 27 '21 17:01 nrayapati

Really appreciate any feedback and steps to get this merged and released soon. Thank you!

nrayapati avatar Feb 12 '21 21:02 nrayapati

I have not updated this to deal with autoformatting.

The steps needed:

$ git merge task/formatting-base
# resolve conflicts
$ mvnd spotless:apply && git commit -am "Apply autoformatting" && git merge -Xours upstream/master

bitwiseman avatar Mar 04 '21 19:03 bitwiseman

@bitwiseman Thank you for the feedback and addressed it.

nrayapati avatar Mar 05 '21 14:03 nrayapati

In my case this doesn't solve the underlying issue, in a multibranch pipeline job I would still need one credential per organization to do the repository scan.

carlossg avatar Mar 07 '21 11:03 carlossg

@bitwiseman Any other thoughts on this change?, looks like we have closed the other PR that carlossg proposed

nrayapati avatar May 04 '21 18:05 nrayapati

Hi all, Thanks for that work! I'm not a Jenkins developer, but highly interested in getting this feature integrated. (My use-case is a single Github app by our institution, for internal customers in different Github Orgs) I would like to provision the Github App Credentials once in Jenkins, and reuse it in the context of different Github Org owners.

How can I help to get this merged and released? Best, Erich

ebirn avatar Dec 28 '21 11:12 ebirn

Not sure I see the point of this. You can already specify an owner…?

jglick avatar Mar 23 '22 19:03 jglick

Perhaps #527 covers your requirement.

jglick avatar Mar 23 '22 20:03 jglick