cppcheck-plugin icon indicating copy to clipboard operation
cppcheck-plugin copied to clipboard

Jenkins 35096 altran cppcheck plugin pipeline support

Open AltranManatree opened this issue 8 years ago • 9 comments

Add support for ccpcheck pipeline jenkins 2.0

Note: Another feature branch, jenkins-35096_cppcheck_plugin_pipeline_support already exists, but due to the fact it is still open in Jenkins jira. We are pushing our finished working cppCheck plugin for review.

Our plugin has been tested in our working environment, and is working correctly in jenkins V2 pipeline. As an addition, the step can be called as follows:

                  **CppcheckPublisher ( pattern: ‘cppcheck.xml’ )** 

instead of

step([$class: 'CppcheckPublisher', allowNoReport: false, displayAllErrors: true, displayErrorSeverity: false, displayInformationSeverity: false, displayNoCategorySeverity: false, displayPerformanceSeverity: false, displayPortabilitySeverity: false, displayStyleSeverity: false, displayWarningSeverity: false, failureThreshold: '', healthy: '', ignoreBlankFiles: false, newFailureThreshold: '', newThreshold: '', numBuildsInGraph: 0, pattern: 'cppcheck.xml', severityError: true, severityInformation: true, severityNoCategory: true, severityPerformance: true, severityPortability: true, severityStyle: true, severityWarning: true, threshold: '', unHealthy: '', xSize: 500, ySize: 200])

AltranManatree avatar Aug 24 '17 15:08 AltranManatree

Any chance you could share your build? I'd like to test it.

kerrhome avatar Sep 25 '17 18:09 kerrhome

Hi Kerrhome,

Yes, we have a build branch that you can check. see : https://github.com/AltranManatree/cppcheck-plugin/tree/jenkins-35096_Altran_cppcheck_plugin_pipeline_support

AltranManatree avatar Sep 26 '17 08:09 AltranManatree

I believe this looks good. From https://github.com/jenkinsci/cppcheck-plugin/pull/36#issuecomment-323720430:

"Hi, I'm no longer interested in this plugin and mainly I don't have any time for testing of the changes and releasing of a new version. Please become a maintainer and ask for the permissions.

https://wiki.jenkins.io/display/JENKINS/Adopt+a+Plugin"

Any chance you're prepared to do that?

jsiverskog avatar Oct 04 '17 12:10 jsiverskog

Any way to get the build artifact for this?

yitshakyarom avatar Oct 19 '17 22:10 yitshakyarom

@yitshakyarom, yes simple git clone https://github.com/AltranManatree/cppcheck-plugin/tree/jenkins-35096_Altran_cppcheck_plugin_pipeline_support and run "mvn install"

kumbasar avatar Oct 20 '17 05:10 kumbasar

Hi,

I have never worked with Maven, and it seems that I have some security issue on my laptop preventing some part of it… When do you expect this to be merged into the plug in main branch? Is there an active maintainer for this plug-in?

Thanks Yitzik

From: kumbasar [mailto:[email protected]] Sent: Friday, October 20, 2017 8:45 AM To: jenkinsci/cppcheck-plugin Cc: Yitshak Yarom; Mention Subject: Re: [jenkinsci/cppcheck-plugin] Jenkins 35096 altran cppcheck plugin pipeline support (#37)

@yitshakyaromhttps://github.com/yitshakyarom, yes simple git clone https://github.com/AltranManatree/cppcheck-plugin/tree/jenkins-35096_Altran_cppcheck_plugin_pipeline_support and run "mvn install"

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/jenkinsci/cppcheck-plugin/pull/37#issuecomment-338111612, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AeRVLZT3lQmjjYoYWHdhelKfYX1CreExks5suDNvgaJpZM4PBhCk.

yitshakyarom avatar Oct 22 '17 05:10 yitshakyarom

I'm using this with Jenkins 2.89.2 and while it does give us the summary block on the individual build pages, if we click on the link to drill down into the cppcheck data, I get the following screen (pipeline and non-pipeline builds result in the same):

Stack trace

org.apache.commons.jelly.JellyTagException: jar:file:/var/lib/jenkins/plugins/cppcheck/WEB-INF/lib/cppcheck.jar!/org/jenkinsci/plugins/cppcheck/CppcheckResult/index.jelly:3:62: <st:include> No page found 'sidepanel.jelly' for class org.jenkinsci.plugins.cppcheck.CppcheckResult

Does anyone else see this?

kerrhome avatar Jan 30 '18 22:01 kerrhome

Looks like this is the bug: https://issues.jenkins-ci.org/browse/JENKINS-41704

kerrhome avatar Feb 01 '18 22:02 kerrhome

I solved the conflicts and made fixes in pull request #39

michael-doubez avatar May 02 '18 07:05 michael-doubez