cppcheck-plugin icon indicating copy to clipboard operation
cppcheck-plugin copied to clipboard
verified publisher icon jenkinsci

Update parent pom

Open devc007 opened this issue 2 years ago • 5 comments

allow compilation with java 11

  • [x] Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • [x] Ensure that the pull request title represents the desired changelog entry
  • [x] Please describe what you did

devc007 avatar Dec 25 '23 23:12 devc007

Help Needed

I have tried everything but I couldn't figure out how to pass all the checks.

devc007 avatar Dec 27 '23 06:12 devc007

Do I need to change more in pom.xml file like changing tha packaging type?

devc007 avatar Jan 01 '24 20:01 devc007

Do I need to change more in pom.xml file like changing the packaging type?

No. The changes you've made are correct and complete. The Jenkinsfile that is run by ci.jenkins.io is from the master branch, nof from your pull request. I used my admin privileges on ci.jenkins.io to run the job with your Jenkinsfile.

MarkEWaite avatar Jan 01 '24 21:01 MarkEWaite

Mark can you tell me what should i do in my upcoming Pull request so that all the checks will pass in first go? Is this possible?

devc007 avatar Jan 02 '24 06:01 devc007

Mark can you tell me what should i do in my upcoming Pull request so that all the checks will pass in first go? Is this possible?

If you are changing the Jenkinsfile and are not a maintainer of the plugin, then your changes will not be executed by ci.jenkins.io because we don't want the ci.jenkins.io executors to be misused by malicious users submitting changes to a Jenkinsfile

MarkEWaite avatar Mar 06 '24 05:03 MarkEWaite