Jeff Lau

icon indicating a website link http://www.jefflau.net

icon location Taipei icon location Javascripter. Climber. Developer at @ensdomains. Distilling the complicated in simple ways

Results 47 comments of Jeff Lau

add interface cmd to hardhat

Any ideas why the tests are failing?

Lockable resolver

From a high level, should we consider adding a function or functions that will first check if is a) wrapped, and b) has burnt `CANNOT_SET_RESOLVER` and then c) the record...

Replace abstract NameResolver contract with import in ReverseRegistrar.sol

Thanks for this! Sorry we've been busy and I haven't been able to check external PRs for a while. Happy to merge this if we can resolve the conflicts!

ETHRegisterControllerV2

Awesome stuff! There are a few changes we made post audit, so this will need to be merged into your V2 code as well. One example is: https://github.com/ensdomains/ens-contracts/blob/master/contracts/ethregistrar/ETHRegistrarController.sol#L308 Please have...

Wrapped domain expiry date mismatched

You mean on testnet? The UI currently does not support the wrapper yet. We will be releasing support for it in our new UI. If you want to renew it...

Feature/generate index js

This adds every Solidity contract into index.js, but I'm not sure if we want to expose every contract, such as pure testing contracts: ``` const TestNameEncoder = require('./build/contracts/TestNameEncoder') const TestRRUtils...

`try`/`catch` for `abi.decode()` or `abi.tryDecode`

Hi all. I'm also looking for this feature, would be nice to be able to catch and throw a specific error