HTTP_OAuth icon indicating copy to clipboard operation
HTTP_OAuth copied to clipboard

Failed test

Open remicollet opened this issue 12 years ago • 1 comments

1) HTTP_OAuth_MessageTest::testGetParametersIsSorted
Only variables should be passed by reference

/dev/shm/extras/BUILD/php-pear-HTTP-OAuth-0.3.0/HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php:68

Trivial fix.

diff -up HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php.old HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php
--- HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php.old   2013-11-02 07:11:48.511779978 +0100
+++ HTTP_OAuth-0.3.0/tests/HTTP/OAuth/MessageTest.php   2013-11-02 07:11:21.471684361 +0100
@@ -65,7 +65,8 @@ class HTTP_OAuth_MessageTest extends PHP
         $params = array('z' => 'foo', 'a' => 'bar');
         $m = new HTTP_OAuth_MessageMock;
         $m->setParameters($params);
-        $this->assertEquals('bar', reset($m->getParameters()));
+        $param = $m->getParameters();
+        $this->assertEquals('bar', reset($param));
     }

     public function testMagicGetter()

remicollet avatar Nov 02 '13 06:11 remicollet

I just noticed that this repo only contains version 0.2.3 sources...

Where are the 0.3.0 sources ? So, the link from pear.php.net probably need to be fixed

remicollet avatar Nov 02 '13 06:11 remicollet