rescript-apollo-client icon indicating copy to clipboard operation
rescript-apollo-client copied to clipboard

compiles with rescript@next (11-rc4)

Open AlexMoutonNoble opened this issue 2 years ago • 2 comments

AlexMoutonNoble avatar Oct 11 '23 23:10 AlexMoutonNoble

Thanks much for this! I made a couple comments. I think we'll have to remember to update package.json to allow rescript 11 as well.

I've sort of been waiting for the official migration documentation to come out before tackling this, but wondered if it would be possible for library authors to simply specify uncurried: false in bsconfig. At any rate, the set of required changes seem pretty minimal so maybe this is better regardless.

jeddeloh avatar Oct 12 '23 13:10 jeddeloh

Hi Joel Looking at my branch its coming from a very old place in the repo. (I had a fork already and it didnt update before i got into it) Let me try again today, and lets look at it again.

Thanks A

On Thu, Oct 12, 2023 at 6:53 AM Joel Jeddeloh @.***> wrote:

Thanks much for this! I made a couple comments. I think we'll have to remember to update package.json to allow rescript 11 as well.

I've sort of been waiting for the official migration documentation to come out before tackling this, but wondered if it would be possible for library authors to simply specify uncurried: false in bsconfig. At any rate, the set of required changes seem pretty minimal so maybe this is better regardless.

— Reply to this email directly, view it on GitHub https://github.com/jeddeloh/rescript-apollo-client/pull/153#issuecomment-1759656732, or unsubscribe https://github.com/notifications/unsubscribe-auth/APRNFBVKFKAEGMISXB54DLLX67Y4NANCNFSM6AAAAAA54XICNY . You are receiving this because you authored the thread.Message ID: @.***>

AlexMoutonNoble avatar Oct 12 '23 16:10 AlexMoutonNoble