nutui-react icon indicating copy to clipboard operation
nutui-react copied to clipboard

feat(navbar): 多端适配,demo icon使用占位符

Open irisSong opened this issue 1 year ago • 1 comments

🤔 这个变动的性质是?

  • [ ] 新特性提交
  • [ ] 日常 bug 修复
  • [ ] 站点、文档改进
  • [ ] 演示代码改进
  • [ ] 组件样式/交互改进
  • [ ] TypeScript 定义更新
  • [ ] 包体积优化
  • [ ] 性能优化
  • [ ] 功能增强
  • [ ] 国际化改进
  • [ ] 重构
  • [ ] 代码风格优化
  • [ ] 测试用例
  • [ ] 分支合并
  • [ ] 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • [ ] 文档已补充或无须补充
  • [ ] 代码演示已提供或无须提供
  • [ ] TypeScript 定义已补充或无须补充
  • [ ] fork仓库代码是否为最新避免文件冲突
  • [ ] Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

  • 新功能

    • 更新了导航栏组件版本,可能引入了新特性和改进。
    • 增强了对右到左(RTL)布局的支持,改善多语言应用的可用性。
  • 界面改进

    • 精简了导航栏和标签组件的样式,提升了视觉一致性。
    • 引入了条件渲染,以适应不同平台(如React Native和HarmonyOS)。
    • 改善了导航栏的响应性和视觉一致性,适应不同平台的显示需求。
  • 样式调整

    • 更新了导航栏的布局和对齐方式,增强了响应性。
    • 修改了导航栏的背景色和阴影效果,改善视觉呈现。
    • 引入新的样式对象,改善标题和描述文本的可读性。
  • 小错误修复

    • 改善了导航栏组件的点击反馈,确保一致的用户体验。

irisSong avatar Sep 13 '24 02:09 irisSong

Walkthrough

此次更改主要涉及对src/config.json文件中多个组件的版本号进行更新,所有相关组件的版本均从2.0.0提升至3.0.0,包括NavBarInputInputNumberRangeSwitchTextAreaAvatarAvatarGroupCountDownPaginationPriceProgressSwiperSwiperItem。此外,NavBar组件的实现也进行了改进,以支持右到左(RTL)布局和响应式设计。

Changes

文件 更改摘要
src/config.json 更新多个组件的版本号,从2.0.0提升至3.0.0,包括NavBarInputInputNumberRangeSwitchTextAreaAvatarAvatarGroupCountDownPaginationPriceProgressSwiperSwiperItem
src/packages/navbar/navbar.taro.tsx 添加useRtlharmonyAndRnpxTransform的导入,更新了renderLeftrenderContentrenderRight函数以支持RTL布局,修改了useEffect中的逻辑以调整宽度计算。
src/packages/navbar/navbar.tsx 添加useRtl导入,更新了renderLeftrenderContentrenderRight函数以支持RTL布局,增强了样式逻辑,确保动态调整类名以适应RTL和标题对齐。
src/packages/navbar/demos/taro/demo1.tsx 添加TextpxTransform的导入,更新了NavBar组件的结构以提高与Taro组件结构的一致性,增强了平台特定的渲染逻辑。
src/packages/navbar/demos/taro/demo2.tsx 更新了NavBar组件的结构,使用Text组件替代span元素,增强了布局控制,改进了样式以实现响应式设计。
src/packages/navbar/demos/taro/demo3.tsx 更新了NavBar组件的结构,使用Text组件替代span,增加了条件渲染逻辑以适应平台兼容性。

Possibly related PRs

  • #2299: 此PR更新了src/config.json文件,以增量更新Toast组件的版本,类似于主PR中对多个组件的版本更新。
  • #2343: 此PR更新了AvatarAvatarGroup组件的版本号,与主PR中的版本更新一致。
  • #2401: 此PR涉及对src/config.json文件的更改,具体与组件的版本更新相关,直接连接到主PR的更新。
  • #2540: 此PR更新了TrendArrow组件的版本号,与主PR中的版本更新一致。
  • #2670: 此PR更新了InfiniteLoading组件的版本号,与主PR中的版本更新一致。
  • #2703: 此PR更新了@nutui/replace-icons依赖的版本,与主PR中的组件版本更新相关。

Suggested labels

size/XXL

Suggested reviewers

  • xiaoyatong
  • Alex-huxiyang

Poem

🐇 在草地上跳跃,欢快无比,
NavBar更新,版本新奇。
样式简化,布局更美,
兔子欢呼,乐在其中,
让我们一起,享受这变化,
在每个角落,都是新风景! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 9857de21616700354f26e8deb8a1ec63ea77cce5 and 4e55a10b946659c6504ee948f05c6d10c82aa62c.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • src/config.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/config.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 13 '24 02:09 coderabbitai[bot]

Codecov Report

Attention: Patch coverage is 96.15385% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.95%. Comparing base (16b173e) to head (4e55a10). Report is 9 commits behind head on V3.0.

Files with missing lines Patch % Lines
src/packages/navbar/navbar.tsx 96.15% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             V3.0    #2594   +/-   ##
=======================================
  Coverage   83.95%   83.95%           
=======================================
  Files         221      221           
  Lines       17842    17842           
  Branches     2675     2675           
=======================================
  Hits        14980    14980           
  Misses       2857     2857           
  Partials        5        5           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 05 '24 02:11 codecov[bot]