youtube-transcript-api icon indicating copy to clipboard operation
youtube-transcript-api copied to clipboard

Add asynchronous HTTP and bulk fetching to enhance performance

Open kaya70875 opened this issue 6 months ago • 3 comments

kaya70875 avatar Aug 20 '25 16:08 kaya70875

any chance this could get a review @jdepoix ?

0xRaduan avatar Sep 18 '25 20:09 0xRaduan

Hi @0xRaduan @kaya70875, First of all, thank you for your contribution @kaya70875! I only had a very brief look at this, but it does not seem to follow the approach that has been discussed in #514 (refactoring TrascriptListFetcher to be async and wrapping sync call with asyncio.run in YouTubeTranscriptApi). Refactoring TrascriptListFetcher instead of adding TranscriptListFetcherAsync, would also make the code much easier to review, as it seems to contain a lot of copy-pasted code from TranscriptListFetcher. I will have a closer look at this if these changes get implemented! 👍

jdepoix avatar Sep 19 '25 08:09 jdepoix

@jdepoix Thanks for feedback. I guess I misunderstood, I thought we should not refactor anything and use existing modules to create YoutubeTranscriptAsyncApi class. That's why there is too much code duplication.

I'll refactor my PR accordingly based on your suggestions.

kaya70875 avatar Sep 24 '25 14:09 kaya70875