JCStockGraph icon indicating copy to clipboard operation
JCStockGraph copied to clipboard

I made some change. Please review whether the change is suitable.

Open derjohng opened this issue 11 years ago • 3 comments

  1. Major, I add "Today stock price" feature.
  2. Change iOS6, AFNetwork1.3.x support. (But, I am not sure whether that will cause AFNetwork 2.x not work??)
  3. Reorder "5 year/1year/..." to "1 week/month/..."

derjohng avatar Aug 20 '14 03:08 derjohng

Some of these changes are definitely good, but there are some that I don't necessarily want to merge into master. For example, there were breaking changes from AFNetworking 1.x -> 2.x, so if I had to choose I would rather support 2.x.

Furthermore, you've done some things like disable caching by default which I would definitely prefer to be enabled by default. I can address these issues myself, or you could if you'd like.

Could you perhaps explain the "Today stock price" feature you mentioned? It's not immediately clear to me what you mean by this.

jconst avatar Aug 25 '14 18:08 jconst

ichart.finance.yahoo.com/table.csv only provide the prices till yesterday, not include today's price. So, I supplement today price from download.finance.yahoo.com/d/quotes.csv.

derjohng avatar Aug 26 '14 00:08 derjohng

Ah, I see, very good. I had considered doing that as well, glad you've implemented it. I'll have to address these changes soon.

jconst avatar Aug 27 '14 16:08 jconst