juice-interface icon indicating copy to clipboard operation
juice-interface copied to clipboard
verified publisher icon jbx-protocol

Make the timestamp on activity items clickable

Open aeolianeth opened this issue 3 years ago • 6 comments

Problem to solve

In the activity feed, we show the time of the activity, and small button that links to the transaction on Etherscan.

Screen Shot 2022-04-21 at 10 47 13 am

Proposal

Remove the link icon button, and make the timestamp the link to the transaction on Etherscan.

The timestamp should have the same styling as currently, but underline on hover. Links should be opened in a new window (potentially use ExternalLink component: src/components/shared/ExternalLink.tsx)

aeolianeth avatar Apr 21 '22 01:04 aeolianeth

@aeolianeth how to assign this issue to me ? I am new here

ritsuyan avatar Apr 22 '22 10:04 ritsuyan

something confused me. I am on the main branch.

  1. the link icon already removed.
  2. on the '0x....' wallet address text already link to the Etherscan after click.
  3. the '19 hours ago' text has a timestamp tooltip when hover the itself. so should just click the text link to the Etherscan meanwhile remove the tooltip ? @aeolianeth

ritsuyan avatar Apr 23 '22 15:04 ritsuyan

@ritsuyan the proposal is to "Remove the link icon button, and make the timestamp the link to the transaction on Etherscan."

current proposal (hover state)
Screen Shot 2022-04-28 at 8 52 23 pm Screen Shot 2022-04-28 at 8 52 08 pm

Clicking "9 hours ago" should link to the transaction in Etherscan. The "9 hours ago" should be underlined on-hover.

Let me know if you need further clarification! 🙏

aeolianeth avatar Apr 28 '22 11:04 aeolianeth

@ritsuyan the proposal is to "Remove the link icon button, and make the timestamp the link to the transaction on Etherscan."

current proposal (hover state) Screen Shot 2022-04-28 at 8 52 23 pm Screen Shot 2022-04-28 at 8 52 08 pm Clicking "9 hours ago" should link to the transaction in Etherscan. The "9 hours ago" should be underlined on-hover.

Let me know if you need further clarification! 🙏

but under the timestamp already has a wallet address that can link to to the transaction in Etherscan when hover it.

ritsuyan avatar May 02 '22 09:05 ritsuyan

@ritsuyan

the current functionality

  • the wallet address below the timestamp links to the wallet address.
  • the link icon links to the transaction.

what we want:

  • remove the link icon, which currently links to the transaction.
  • make the timestamp ("9 hours ago") link to the transaction instead. It should be underlined on-hover to indicate that it is a link.
  • keep the wallet address as-is

aeolianeth avatar May 06 '22 03:05 aeolianeth

https://user-images.githubusercontent.com/35680780/167772265-b7bee7f1-773b-4b1e-8ce4-df83fa35d2cb.mov

Solved in https://github.com/jbx-protocol/juice-interface/pull/980

deeayeen avatar May 11 '22 04:05 deeayeen