gremlin-javascript icon indicating copy to clipboard operation
gremlin-javascript copied to clipboard

Improve browser support with tests and slim dependencies

Open jbmusso opened this issue 9 years ago • 3 comments

Browser support should be improved:

  • add appropriate tests
  • remove dependencies/unsure the slimmest possible bundle

jbmusso avatar Mar 14 '16 19:03 jbmusso

FYI iOS browsers run in strict mode and throw the following error:

Const declarations are not supported in strict mode.

dmill-bz avatar Mar 16 '16 17:03 dmill-bz

This is weird. The code published to npm (and its dependencies) is transpiled to ES5 and shouldn't have any const declarations (only var). Could you be more specific as to how you import the client to your application?

jbmusso avatar Mar 19 '16 14:03 jbmusso

I originally thought it was because of some of your dependencies (and you excluding node_modules from webpack). But looking at the code again it seems to remove all const appropriately. Wonder why the behavior on gremlin-bin is different. I'll give this another look.

dmill-bz avatar Mar 19 '16 16:03 dmill-bz