jbaehr
jbaehr
I saw it too late -- this PR is very similar to #53.
> Would you mind testing #53? Yes, it works alike -- tested with FreeCAD 0.22.0dev.37578, build locally on macOS
I think "remove outside or a sketch" is not always the same as "use common instead of cut". The use of "common" works only for 3D primitives like a cube...
In the current form this PR effectively breaks CAM completely. With the `if` statement commented, but the else branch remaining indented, importing these files immediately results in an IndentationError. I...
Note that the new method of calculating the minor diameter for threaded holes results in slightly smaller values than the original. The new method uses the theoretical thread profile to...
> Is there a standard for drilled holes before tapping? Yes, there is the DIN 336 and ISO 2306. However, @alfrix is also right -- there is more than tapping....
> a solution would be use a checkbox label as "Tapped" and when ticked it would use a recommended drill size for tapping. This would be an option, yes. And...
> It sounds like pending that change this will be ready to merge, @jbaehr ? Yes. - If we restore the custom taper angles (i.e. remove commit 8a417943d743912225a5b39814e2a7e1603b3fce from here...
I think we're nearly there. Now not only the ISO 2306 tab drill sizes are back in, the tables are also extended for the corresponding Whitworth tap drill sizes from...
Just compiled and tried the most recent version. Looks good to me and works as expected (including opening an older file with a custom taper angle).