tablib icon indicating copy to clipboard operation
tablib copied to clipboard

feat: support column_width in xlsx format

Open Birdi7 opened this issue 4 years ago • 6 comments

This PR allows user to specify column width in XLXS format. For it has a default value, which is not suitable for long values in dataset. As a result, it is not convenient to look these tables. Also, it eliminates questions like #318 in future

I didn't find tests for exporting, so omitted this. Let me know if they are required

Birdi7 avatar Feb 17 '22 10:02 Birdi7

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.11%. Comparing base (de1a47a) to head (0f7e2ef). Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #516      +/-   ##
==========================================
+ Coverage   90.84%   91.11%   +0.27%     
==========================================
  Files          28       28              
  Lines        2664     2702      +38     
==========================================
+ Hits         2420     2462      +42     
+ Misses        244      240       -4     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 17 '22 10:02 codecov[bot]

Hello @hugovk! Sorry for ping, but I just want to ask if you have any time for review and merge this?

Birdi7 avatar Mar 31 '22 13:03 Birdi7

@hugovk Thank you for the review! I've added the test on check the new feature, checkout test_xlsx_column_width. Would you mind review the PR, and if everything is ok merge it to master?

Birdi7 avatar Apr 01 '22 11:04 Birdi7

Thank you for such usefull comment! I've found a bug with new tests. Your comments are pushed, alongside with all three tests. What do you think on it?

Birdi7 avatar Apr 01 '22 12:04 Birdi7

Thank you for your comment! I believe this significantly improves redability. Could please take a look if the PR is fine now?

Birdi7 avatar Jun 08 '22 11:06 Birdi7

Hi there, I would find this enhancement useful. Do you mind to take this last step to add this feature? Thank you!

rakinson avatar Aug 22 '24 12:08 rakinson