hello-friend icon indicating copy to clipboard operation
hello-friend copied to clipboard

Options page to edit the actual object we get back from './objects.js'

Open jaywick opened this issue 7 years ago • 2 comments

jaywick avatar May 17 '18 01:05 jaywick

Hello!
Do you want help with this?

I've been using the extension for years (thank you for it!) and used it as a playground of sorts for a while, and pushed some of that to a fork I had today since I'm switching devices. There's some work which can be built on for a decent options page.

Since I had other changes in my personal copy, I quickly put together some hacky integration of the options page (everything in script.js into a function, called when the stored options get loaded) to your upstream, https://github.com/jaywick/hello-friend/compare/master...ziyadss:hello-friend:options-to-upstream

It's missing input validations, and the input areas for the two array members aren't user-friendly, but they work.

Two other notes:

  • Updated manifest_version to v3 since v2 is deprecated and will no longer work next year.
  • ROOT_FOLDER stored as a string since chrome.storage does not support objects with functions (RegExp.test() being the culprit here), with the pattern object being instantiated in script.js

image

ziyadss avatar Jun 28 '22 18:06 ziyadss

Hey @ziyadss! This looks awesome and glad to know you've found the extension useful 😀 Thank you for offering to contribute, I haven't looked thoroughly at the code yet but from the screenshot and your description it sound awesome. I'll make a PR to merge back upstream at some point (a little busy with work and life so might take a while 🙏)

jaywick avatar Jul 04 '22 06:07 jaywick