danfojs icon indicating copy to clipboard operation
danfojs copied to clipboard

Fixed Replacing a value with 0 with dataframe.replace throws an error

Open junduck opened this issue 3 months ago • 0 comments

Fixes #621

The original implementation wrongly tests falsy on oldValue and newValue, which results in throwing when replacing with falsy values like 0 or empty string.

This fix test for undefined instead, then validates oldValue/newValue types.

This fix is trivial so no test coverage.

  • Previous PR was closed due to editor removal of whitespace that spamming diff log

junduck avatar Nov 12 '25 15:11 junduck