danfojs icon indicating copy to clipboard operation
danfojs copied to clipboard

Version 1.1.1 published to NPM does not match release 1.1.1 in GitHub

Open ptohara14 opened this issue 3 years ago • 0 comments

The published package for danfojs-node 1.1.1 on NPM registry does not match the version 1.1.1 release in this GitHub repository. Specifically it does not contain #441. The version numbers look correct in NPM however the contents of the package are not.

To Reproduce

  1. npm install [email protected]
  2. cat package.json "danfojs-node": "^1.1.1",
  3. less node_modules/danfsjs-node/dist/danfojs-base/core/frame.js Function DataFrame.prototype.fillNa = function (values, options) { .... if (!values && typeof values !== "boolean" && typeof values !== "number") { ....
  4. wget https://registry.npmjs.org/danfojs-node/-/danfojs-node-1.1.1.tgz
  5. tar xvzf danfojs-node-1.1.1.tgz
  6. less package/dist/danfojs-base/core/frame.js .... if (!values && typeof values !== "boolean" && typeof values !== "number") { ....

Expected behavior frame.js expected to contain: Function DataFrame.prototype.fillNa = function (values, options) { .... if (!values && typeof values !== "boolean" && typeof values !== "number" && typeof values !== "string") { ....

Environment:

  • OS: Rockey Linux 8
  • Runtime: Node v14.19.2
  • NPM version: 6.14.17

ptohara14 avatar Jun 20 '22 19:06 ptohara14