Sync bot crushing partial reviews

[joaquinelio]

Hi @iliakan

I discovered this in the Spanish repo, but happens in the other repos too. ...

Previously, the bot used different branches for sync, closing the old PR and generating a new one over a new branch. Partial reviews were preserved in the closed PR.

Now, the bot closes the old PR but always uses the same branch, doing a force push on it that destroys any partial reviews.

[iliakan]

Hmm, I did not change bot behavior.

[joaquinelio]

Ok Maybe AI war started. Dont use my reasoning. Look at this:

This is my work 2 years ago. Bot closed it twice, I reopened it and continued working until I eventually merged

---

Now the bot, AFTER closing it, did a force push erasing my commits

[joaquinelio]

Hmm, I did not change bot behavior.

Sorry to tell you this, @iliakan The world bot vs human war started, in your repo.

Here, bot reverted my test change

It is doing it regularly, with every new sync PR

[iliakan]

So if you do the changes locally, does this kind of resolve the issue?

Trying to get if I need to do something.

P.S. Initially, the idea was that edits are done locally. I hope things work this way.

[joaquinelio]

Yes, I can avoid the issue easily.

, now that I know of it. Not a catastrophic bug anymore.

---

But the bot behavior is odd.

I have a bot-sync example from 2 years ago:

I made changes to the bot PR branch, online. The bot closed it. I reopened it and merged my changes, it worked as expected.

[joaquinelio]

Out of curiosity If local, I do my own merges so I dont need to search <<< === >>> manually.

Plus

if you use the bot's PR locally, you'll lose track of fast-forward modifications, meaning all inserted new text.