Dark Mode

[kkanekii]

Feature Request

Will Dark Mode be ever available on this website? I think it will definitely boost the time view on the website If anyone could do this, it would be AWESOME

[iliakan]

Working on it!

[kkanekii]

Thank You!

[anas40]

I would be happy to do this. Can you also tell me how you are doing this/planning to do this? @iliakan

[iliakan]

We'll use CSS variables and edit all styles to rely on them. Then change CSS variables depending on cookies/user selection.

[kkanekii]

mans I think you forgot

[iliakan]

@gsemikozov please tell us how it goes?

[GSemikozov]

We're planning release it at the beginning of August.

[HamzaAmar]

@iliakan if you need some help for implementing dark mode please let me know

[iliakan]

Thank you, @Gsemikozov is working on it.

[kkanekii]

he quit on it probably by now

[iliakan]

Dear @GSemikozov please tell us about the progress.

[GSemikozov]

sorry guys for the delay - we're almost done, on a final stage right now.

[iliakan]

More work than expected. We're into it.

[kkanekii]

😪 alright

[honeykpatel]

Can't wait for this! ✨

[kkanekii]

@honeykpatel the idea is dead bro they just gave up on it

[honeykpatel]

@kkanekii Oof :') opens dev tools

[iliakan]

In fact, we’re almost done.

Figma service has a problem, it can’t keep text in exported SVGs. And we hoped to use Figma for theming. We found at workaround with Sketch, but not finished yet.

Sorry for the delay.

Best regards, Ilya Kantor

5 окт. 2021 г., в 18:01, kaneki @.***> написал(а):

 @honeykpatel the idea is dead bro they just gave up on it

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

[honeykpatel]

@iliakan Ohh great! It would be worth the wait😍✨ Thank you for your reply.

[ghost]

Until it is ready... I use Kiwi browser night mode :)

[kkanekii]

@iliakan its fine now if this is not getting done since 3 months might as well close the issue

[iliakan]

We have it working, just not deployed yet. I can make a public version and post a link here.

[honeykpatel]

Do it, sir! 😃

[iliakan]

Take a look at https://dark.javascript.info. Login: dark, password: mode.

Frontpage is not themed, as of now. You can find theme switch in articles (I hope so).

Please leave your feedback at https://docs.google.com/forms/d/e/1FAIpQLSfPZGs62me8x5UIv_JNbyODxk78tmbl5YyBJ_yrkhM9xt4UdQ/viewform and maybe here ;)

[honeykpatel]

Is it just me or the homepage is still in light mode? But the chapters looks so cool in dark mode 🤩

[iliakan]

Frontpage is not themed, as of now.

[ShivamS136]

It's looking great. Slight suggestions:

Seems like Disqus is confused between light and dark mode so it's showing a grey version 😂😂

---

I think it's your dark mode implementation that is making the background grey from white as the same can be seen in sandbox examples too, improvement in this will be really beneficial.

[iliakan]

Please reload the page without browser cache, it should be fine now. Thanks.

[kkanekii]

look great @iliakan well done!!!!

[Manik2375]

Oh that looks super clean and amazing! But there is a problem, and that is disqus comments. When comments section is opened, then if we change the theme, text doesn't change. Reload is the fix, but it's little annoying :sweat_smile:. And all other things look perfect!