mojarra icon indicating copy to clipboard operation
mojarra copied to clipboard

Implicit EL resolver for #{component} erroneously makes resolved outcome conditionally

Open javaserverfaces opened this issue 10 years ago • 7 comments

ImplicitObjectELResolver sets the outcome of whether #{component} is resolved based on the value of the result.

This happens via the following code:

UIComponent c = UIComponent.getCurrentComponent(facesContext);
context.setPropertyResolved(c != null);

This doesn't seem to be correct. Property resolved should be set solely based on whether the resolver handles the property or not (it always does here, so should always be set to true).

javaserverfaces avatar Aug 25 '15 12:08 javaserverfaces

Reported by @arjantijms

javaserverfaces avatar Aug 25 '15 12:08 javaserverfaces

@manfredriem said: Looks good r=mriem

javaserverfaces avatar Sep 04 '15 15:09 javaserverfaces

@arjantijms said: Applied to 2.3 trunk:

svn commit -m "https://java.net/jira/browse/JAVASERVERFACES-4029, resolved no longer depends on value outcome, r=mriem" Sending jsf-ri/src/main/java/com/sun/faces/el/ImplicitObjectELResolver.java Sending test/unit/src/test/java/com/sun/faces/el/ImplicitObjectELResolverTest.java Transmitting file data .. Committed revision 15126.

javaserverfaces avatar Sep 04 '15 15:09 javaserverfaces

@edburns said: Total 0 (delta 0), reused 0 (delta 0) To ssh://[email protected]/mojarra~git e44a592..eb672ce master -> master

Commit eb672ce2bbfbce2879a0480cbaf20978b2bac2d8 reverts 4029 and restores AdminGUIIT to running.

javaserverfaces avatar Sep 30 '15 18:09 javaserverfaces

File: changebundle.txt Attached By: @arjantijms

javaserverfaces avatar Sep 04 '15 14:09 javaserverfaces

This issue was imported from java.net JIRA JAVASERVERFACES-4029

javaserverfaces avatar May 02 '17 10:05 javaserverfaces

Please see this important message regarding community contributions to Mojarra.

https://javaee.groups.io/g/jsf-spec/message/30

Also, please consider joining that group, as that group has taken the place of the old [email protected] mailing list.

Thanks,

Ed Burns

edburns avatar Oct 29 '17 03:10 edburns