Allow multiple uses of WalkthroughElement
Hi @jasongaare ,
thanks for your nice lib! I needed to revisit certain WalkthroughElement and provide a different content for it. You can check my commit here, the code is actually quite straight forward https://github.com/danielwinkler/react-native-walkthrough/commit/a92c7aa96d5115d44ecbac95cbc7d25c88eed13b
It will allow the following
export default [
{
id: 'profile-button',
content: makeTooltipContent('Tap here to view a profile'),
},
{
id: 'profile-name',
content: makeTooltipContent("Here is the user's name"),
},
{
id: 'profile-button',
content: makeTooltipContent('Now tap again!'),
},
];
I also changed the whole module to typescript, which allowed me to understand your implementation
Please let me know if you are interested in
- this feature
- the ts implementation
I would create proper pull request; (unfortunately the current commits don't properly show the differences i did to the file as the filename change from js to tsx at the same time :-(
Wow this is awesome! I am feeling guilty because I am jazzed about this lib and its potential, but just have not had the time to commit (no pun intended) to polishing it.
I would definitely be interested actually in both of those! Thanks for your work on this and your interest in this library
@jasongaare great that you're interested;
I cleaned the history a bit so that it makes more sense. #8 Adds all the typescript related stuff including tsdx, which should allow you to publish it without problems to npm #7 Is the modification to allow multiple uses of the same Element
I separated the two, so you will get some merge conflicts, but given the simplicity of #7 I hope they shouldn't be a problem Otherwise just let me know!
Cheers, Daniel