Fixing height calculation

Open tomasz-adrianowski opened this issue 7 years ago • 3 comments

Mar 14 '18 12:03 tomasz-adrianowski

woops, meant to close #11

Mar 14 '18 13:03 jariz

why exactly do you believe this is needed?
ellipsis.js (which this code is largely if not entirely based on) doesn't do this either:
https://github.com/glinford/ellipsis.js/blob/master/ellipsis.js#L133

Please file a PR over there, and if it gets accepted, I will accept this PR because I don't really bother with the ellipsis internals too much.

Mar 14 '18 15:03 jariz

Ok, thank you for the info. I just noticed that during resizing, the height was not properly calculated, but only for expanding a screen.

Mar 14 '18 15:03 tomasz-adrianowski