jargons.dev icon indicating copy to clipboard operation
jargons.dev copied to clipboard
verified publisher icon jargonsdev

Update navbar.astro

Open pratham12102004 opened this issue 4 months ago • 5 comments

Description

This Pull Request implements the homepage navigation link for the Jargons.dev logo in the header. This follows standard web conventions, allowing users to return to the root page from anywhere on the site, thereby improving general user experiencefix(logo): Add homepage link to the Logo component #200

Related Issue

Fixes #200

Screenshots/Screencasts

before and after image of code is uploded

Notes to Reviewer

The required link was implemented in src/components/navbar.astro. I wrapped the existing <JargonsdevLogo> component with an anchor tag () set to the site root (href="/"). No new npm image (1)

pratham12102004 avatar Sep 28 '25 16:09 pratham12102004

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
jargons-dev Ready Ready Preview Comment Sep 28, 2025 4:16pm

vercel[bot] avatar Sep 28 '25 16:09 vercel[bot]

hey please accept my merge request

pratham12102004 avatar Sep 30 '25 14:09 pratham12102004

@babblebey The Requested changes has been implemented and pushed 1.The logo component class has been updated to restore the md:h-12 class for proper scaling on large devices. 2,. I have run the project's formatter (npm run format) to ensure all code style issues are resolved and CI checks will pass. 0002 0001

pratham12102004 avatar Oct 02 '25 15:10 pratham12102004

Okay @pratham12102004

I think you might have forgotten to push the change 😉

babblebey avatar Oct 02 '25 22:10 babblebey

Hi @pratham12102004

It's been a moment you pushed any change here, the PR is now stale, I hope you're well... is there any chance you're able to conclude this soon!?

😉

babblebey avatar Oct 18 '25 17:10 babblebey