masonic icon indicating copy to clipboard operation
masonic copied to clipboard

ResizeObserver polyfill should be provided through a prop instead of included in the bundle

Open aalpgiray opened this issue 2 years ago • 2 comments

Hey!

We noticed "@juggle/resize-observer": "^3.3.1", package is in dependencies. But depending of the target browsers that might not be needed. Can we remove this from the bundle and add this as optional peer dependency or to the documents. This will reduce the bundle size. Here is the analysis. image

aalpgiray avatar Nov 20 '23 12:11 aalpgiray

All things considered the bundle size is not a big problem. However, I agree that in this day and age it'd be nice to have a ResizeObserver polyfill be provided as a prop rather than included in the bundle.

jaredLunde avatar Feb 16 '24 23:02 jaredLunde

I would accept a PR for this btw

jaredLunde avatar Feb 16 '24 23:02 jaredLunde