Jan Schäfer

Results 70 comments of Jan Schäfer

Did you test your PR with Kotlin? Because your code uses `instanceof Object[]`. I assume that this will not work for the Kotlin Array type.

I am always open for PR :-). The question is whether a whole jgiven-kotlin module is not a bit of an overkill for just a single annotation. How would such...

Sounds like a good idea. There is one problem though. If the stage has a `@BeforeScenario` annotation, the corresponding method cannot be executed anymore before the complete scenario, because JGiven...

Well, I guess you are right. `@BeforeScenario` should be in most cases identical to `@BeforeStage` which is also only executed once before the stage. This is in contrast to `@AfterScenario`...

Well, if we would introduce a mechanism like the one you are describing and @BeforeScenario would only behave differently in this case then this would also be fine as there...

As far as I can evaluate it (I am not a Kotlin developer) it looks good. I am not a big fan of all uppercase GIVEN, WHEN, THEN, but I...

Not yet. I was not even aware of ReportPortal. However, as JGiven has no own test runner, the JUnit or TestNG integration can be used, I think. What else would...

Yes. That is a very good point. I already thought about that issue and didn't come up with a good solution yet, so I would be very happy about suggestions....

Issue #71 is somehow related to this one.

I finished a first implementation for grouping, sorting, and filtering. It is tracked now by PR #81. There is a live demo here: http://jgiven.org/snapshot/jgiven-report/html5/#/all If you want to test it...