WebLoader icon indicating copy to clipboard operation
WebLoader copied to clipboard

Fixed filter failure on unescaped urls

Open juniwalk opened this issue 9 years ago • 12 comments

Related #97

juniwalk avatar Feb 23 '16 15:02 juniwalk

@fprochazka Alright I am satisfied, could you check it out?

juniwalk avatar Feb 23 '16 16:02 juniwalk

It seems like you're solving three different issues at once, which is a bit confusing for me to review :-/

fprochazka avatar Feb 24 '16 11:02 fprochazka

What do you mean by three different issues?

juniwalk avatar Feb 24 '16 11:02 juniwalk

@fprochazka I've fixed the greedines but I can't remove the trim nor undo the modification of the condition. If you wan't I can split this code into several commits.

juniwalk avatar Feb 24 '16 17:02 juniwalk

@fprochazka You were right, this pull is starting to get little big. Too bad there weren't more tests for this filter in the first place, this would have been much easier.

juniwalk avatar Feb 28 '16 19:02 juniwalk

@fprochazka ping, probably busy, right?

juniwalk avatar Mar 07 '16 08:03 juniwalk

@juniwalk I'm scared of the regexp changes, I'm gonna have to dive into it and verify it works as expected - which will take time :)

fprochazka avatar Mar 08 '16 17:03 fprochazka

@fprochazka I see, I hoped to cover this in the style.css --> style.css.expected test case, anyway if you need me to add more cases or change something just let me know.

juniwalk avatar Mar 08 '16 19:03 juniwalk

@fprochazka Hello, any news? I've spent last hour finding one issue only to discover that it is this issue with webloader again.

juniwalk avatar Apr 18 '16 10:04 juniwalk

Sorry, no time for this so far.

fprochazka avatar Apr 19 '16 10:04 fprochazka

I've redirected composer to my cloned copy so I use the changes I've made. It's okay for now but not ideal.

juniwalk avatar Apr 19 '16 11:04 juniwalk

@fprochazka Hello, still no time? Last commit was 7 months ago, looks like this repo is being "abandoned" :/

juniwalk avatar Jul 20 '16 08:07 juniwalk