cortex.cpp icon indicating copy to clipboard operation
cortex.cpp copied to clipboard

bug: App shell conflicts between `cortex-nightly` and `cortex-stable`

Open gabrielle-ong opened this issue 1 year ago • 7 comments

Cortex version

v172

Describe the Bug

App shell conflicts between cortex-nightly and cortex-stable:

when I load a model on one version, the model is loaded on both cortex and cortex-nightly when I unload the model on one version, the model is unloaded on both cortex and cortex-nightly

Not sure if this is a cortex ps issue or installation/data folder conflict with cortex and cortex-nightly

Steps to Reproduce

No response

Screenshots / Logs

image

What is your OS?

  • [X] MacOS
  • [ ] Windows
  • [ ] Linux

What engine are you running?

  • [X] cortex.llamacpp (default)
  • [ ] cortex.tensorrt-llm (Nvidia GPUs)
  • [ ] cortex.onnx (NPUs, DirectML)

gabrielle-ong avatar Oct 16 '24 09:10 gabrielle-ong

Our CLI and Server communicate by TCP IP socket for now and the Server does not know about cortex variant, so it is expected. This will be solved after we support Unix domain socket cc: @namchuai @nguyenhoangthuan99

vansangpfiev avatar Oct 16 '24 23:10 vansangpfiev

@vansangpfiev do we have plans to move to UDS, and should this be done earlier rather than later?

cc @dan-homebrew @0xSage

gabrielle-ong avatar Oct 17 '24 02:10 gabrielle-ong

Decision:

  • move Bug to icebox (Sprints: 2 sprints away)
  • create new Epic on moving to Unix Domain Sockets (Size: Large, Status: Planning)

gabrielle-ong avatar Oct 17 '24 02:10 gabrielle-ong

Dumb/nonurgent question: If we switch to UDS, what about devs directly embedding Cortex in their apps and only using the API? Will we still support TCP/IP (the most common protocol)?

freelerobot avatar Oct 17 '24 03:10 freelerobot

IMO, we will support both UDS and TCP/IP. Clients (CLI, Jan, ...) can switch to which protocol they want.

vansangpfiev avatar Oct 17 '24 05:10 vansangpfiev

@gabrielle-ong A temporary solution for TCP/IP is to use different ports by configuring apiServerPort in .cortexrc*.

vansangpfiev avatar Oct 17 '24 06:10 vansangpfiev

Thanks @vansangpfiev, Ill use that workaround iceboxing this bug and creating a planning ticket #1517

gabrielle-ong avatar Oct 18 '24 05:10 gabrielle-ong