gmailr icon indicating copy to clipboard operation
gmailr copied to clipboard

"New" gmail breaks plugin

Open smithygreg opened this issue 7 years ago • 0 comments

Not sure if anyone is maintaining this or interested, but in case someone comes across the same issue I have...

The "new" gmail interface that is being phased in in mid to late 2018 breaks this plugin.
The specific issue happens in line 243 of gmailr.js https://github.com/jamesyu/gmailr/blob/0c588f32278a1dd9b9b934f01bb9785bfa471964/chrome/lib/gmailr.js#L243

Gmail no longer includes the iframe with this script. The script itself is included in the document itself.

This seems to fix the issue. try{ win = top.document.getElementById("js_frame").contentDocument.defaultView; //Old Gmail } catch(e){ win = window; //New Gmail }

Be aware that there are a whole host of other issues that cropped up with this "new" interface...One of which being the format of the data that is sent out (It is no longer a url string...It is now a json object).

smithygreg avatar Oct 15 '18 18:10 smithygreg