lets_code_javascript icon indicating copy to clipboard operation
lets_code_javascript copied to clipboard

Fix socket.io race condition

Open mgrandrath opened this issue 8 years ago • 0 comments

I think this solves the race condition with socket.io. I basically did two things:

  • Make createSocket asynchronous so that it ensures that the new socket is actually connected. This made the tests a lot more stable.
  • Set a timeout for the underlying HTTP server. After removing all the other code the HTTP server did not shut down reliably. After poking around using getConnections() I found that occasionally there is a connection hanging there, preventing done() to be called. I resolved this by setting a timeout on the HTTP server to forcefully shut down all hanging connections.

mgrandrath avatar May 27 '17 17:05 mgrandrath