binrw icon indicating copy to clipboard operation
binrw copied to clipboard

Incorrect error message on enum parsing when a binwrite impl is missing

Open Raytwo opened this issue 4 years ago • 1 comments

While trying out binrw, I implemented a parser using the binrw attribute while I should have been using the binread one instead.

Due to missing a binwrite impl for my struct, I ended up getting an error message, but it was pointing out an error that wasn't relevant, which you can observe on this screenshot: image

As you can see, the enum is properly defined, and the error is already addressed.

Raytwo avatar Feb 19 '22 19:02 Raytwo

Adding to this: the issue is that the BinWrite error is copy/pasted from the binread error

jam1garner avatar Feb 27 '22 07:02 jam1garner

The incorrect error has been fixed by #139 so this can be closed when that lands.

csnover avatar Aug 23 '22 04:08 csnover

This is fixed by c6931d02d60fe7aa4f634e69e4ecb1fecb047b5c. Thanks!

csnover avatar Aug 23 '22 05:08 csnover