jakeday
Non-Ubuntu Distro Accessibility and Formatting
- Fixes for #251 not working on distro without update-rc.d (non-Ubuntu)
- Newline formatting is not default on Fedora/RHEL, so adding
-ebeautifies output - Checks for Ubuntu before even asking user to install Ubuntu packages
The .deb packages work on other apt-based distributions though, and not just on ubuntu. By checking for ubuntu, you wouldn't detect Mint, Debian or Elementary OS I think (definitly not Debian, idk if the others change the ID).
I actually made a pull request that does similar (if not the same, lol)
changes (#538), which just checks for the package manager (i.e. if
apt / dpkg is installed .deb packages are used, and if pacman is
installed the arch packages will work).
Feel free to rip those changes out of my PR in order to simplify merging this if you want.
Oh! I'm sorry about that! I'll include the changes from https://github.com/jakeday/linux-surface/pull/538/commits/b4ddc70ce4759f9d65dffbe1d8abdc67068e1026 in this PR! ( off note but thank you for the fedora packaging! )
Nice!
Oh! I'm sorry about that!
No worries! But actually, one thing I still want to suggest:
In #538 I reorgnized the script a bit so it installs libwacom right before installing the kernel. That allowed me to use only one if / else check for the package manager, instead of two (that need to be kept in sync). Maybe thats something you should add too, to have less duplicated code?
Another note, because I just read that in the planned changelog:
Fedora 31 won't contain the yum wrapper anymore, so checking for that
will fail. The script should check for dnf instead (even if someone
is crazy enough to use these packages on CentOS / RHEL, they are
switching to dnf too - RHEL already did iirc.)
Sorry for nagging xD