MusicBot icon indicating copy to clipboard operation
MusicBot copied to clipboard

[Feature Request] Config option to disallow external url sources

Open MichailiK opened this issue 4 years ago • 4 comments

Is your feature request related to a problem? Please describe. LavaPlayer allows playing of any arbitrary URLs, which some are considering as a security issue.

Describe the solution you'd like A config entry should be added, which allows bot owners to not load tracks from external URL's. YouTube, SoundCloud etc. can still load regardless of this setting

Describe the basic flow/steps of using this feature

    • The bot owner disables the capability of playing from external url sources
    • No one will be able to queue any music outside of YouTube, SoundCloud etc.
    • The bot owner disables the capability of playing from external url sources
    • Everyone will be able to queue any music outside of YouTube, SoundCloud etc.

Additional context Discussed in https://github.com/jagrosh/MusicBot/discussions/744

Originally posted by hermitoff August 29, 2021 Hello,

Do not use your IP to host the bot! Because anyone can find it.

You just have to send to the bot a request (with the command play) to an ip logger to get it.

Here is an example to show you: unknown

I'm sorry to show this to everybody. And don't worry about the IP on the image, I don't care.

MichailiK avatar Sep 15 '21 21:09 MichailiK

I am currently debating whether this would be better as a standalone feature, or to integrate this into transforms.

jagrosh avatar Sep 15 '21 21:09 jagrosh

It would be better, and simpler, to make a whitelist of allowed URLs?

hermitoff avatar Sep 18 '21 14:09 hermitoff

Just wondering if this has been implemented? Would it also be possible to make search default away from YouTube if it were disabled in the conf?

KenaiTheWolf avatar Oct 11 '21 01:10 KenaiTheWolf

We close issues once they are fully implemented. This issue is still open, so it has not been implemented.

MichailiK avatar Oct 11 '21 16:10 MichailiK