node-binance-api icon indicating copy to clipboard operation
node-binance-api copied to clipboard

websocket.userData not working anymore [FOUND A FIX]

Open kasugasorata98 opened this issue 4 years ago • 4 comments

The latest version of 0.13.0 Wrong terniary operator: Binance.options.execution_callback = execution_callback ? callback : execution_callback; Correction: Binance.options.execution_callback = execution_callback ? execution_callback : callback;

kasugasorata98 avatar Sep 09 '21 06:09 kasugasorata98

@kasugasorata98 thanks! this was very useful for me to open #732

gunar avatar Sep 22 '21 16:09 gunar

you just use it wrong, its working in 0.13.0


	function order_update(data) {
		console.log(data)
	}
	binance.websockets.userData(order_update, true);

mr-smit avatar Nov 06 '21 23:11 mr-smit

No, it isn't @mr-smit. In 0.12.5 you could pass different callbacks for different updates from the stream and in 0.13.0 you can't anymore because of this wrong logic.

Any news @gunar ?

luiztools avatar Nov 07 '21 20:11 luiztools

PR is ready just needs merging.

On Sun, 7 Nov 2021, 17:45 Luiz Duarte, @.***> wrote:

No, it isn't @mr-smit https://github.com/mr-smit. In 0.12.5 you could pass different callbacks for different updates from the stream and in 0.13.0 you can't anymore because of this wrong logic.

Any news @gunar https://github.com/gunar ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/jaggedsoft/node-binance-api/issues/728#issuecomment-962677759, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2UDXRTA4L72N5VQNBD2PLUK3QOVANCNFSM5DWLLFAA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

gunar avatar Nov 07 '21 22:11 gunar