node-binance-api Fix orderStatus with orderid

Aug 17 '21 14:08 hkjersem

Hey tried your fix but It's still not working

Oct 08 '21 19:10 Jkurbs

Are you sure? It works for me. What kind of error do you get?

Oct 09 '21 10:10 hkjersem

Thanks for your answer, Here's the error: {"code":-1102,"msg":"Param 'origClientOrderId' or 'orderId' must be sent, but both were empty/null!"}

The code: (The id Is a valid id)

client.orderStatus('ETHUSD', "507439843", (error, orderStatus, symbol) => {
    if (error != null) { return functions.logger.error("An error occured while checking order status: ", error['body'])}
    functions.logger.log(orderStatus)
  });

Binance code:

orderStatus: function ( symbol, orderid, callback, flags = {} ) {
         let parameters = Object.assign( { symbol: symbol }, flags );
         if (orderid){
             Object.assign( { orderId: orderid }, parameters )
             parameters = Object.assign( { orderId: orderid }, parameters )
         }

         if ( !callback ) {
             return new Promise( ( resolve, reject ) => {
                 callback = ( error, response ) => {
                     if ( error ) {
                         reject( error );
                     } else {
                         resolve( response );
                     }
                 }
                 signedRequest( base + 'v3/order', parameters, function ( error, data ) {
                     return callback.call( this, error, data, symbol );
                 } );
             } )
         } else {
             signedRequest( base + 'v3/order', parameters, function ( error, data ) {
                 return callback.call( this, error, data, symbol );
             } );
         }
     },

Oct 09 '21 13:10 Jkurbs

Any help would be appreciated!

Oct 09 '21 17:10 Jkurbs

@pawelangelow

Oct 13 '21 15:10 Jkurbs

orderStatus: function ( symbol, orderid, callback, flags = {} ) {
         let parameters = Object.assign( { symbol: symbol }, flags );
         if (orderid){
             Object.assign( { orderId: orderid }, parameters )
             parameters = Object.assign( { orderId: orderid }, parameters )
         }

Looks like you didn't remove the line here like in the PR, though it shouldn't really matter.

Oct 13 '21 15:10 hkjersem

Removing it doesnt fix it. What should I do?

Oct 13 '21 16:10 Jkurbs

Can you console.log the parameters?

Oct 13 '21 16:10 hkjersem

@hkjersem I finally got it working. I had to fork your repo and install the repo via npm

Oct 14 '21 04:10 Jkurbs

Why isn't this merged ? It is a critical issue