jacquesh
"Apply" and "OK" buttons save lyrics whereas it shouldn't (in Search window)
Version 0.10; Foobar2000 1.6.8; Windows 10 20H2 x64
The addition of button "Apply" is really nice, and allows to compare several versions of lyrics.
Unfortunately, when I click on "Apply" (but it's also the case with "OK") button, it saves the lyrics. In options, I've chosen not to write automatically ("Autosave: never"). I'd like buttons "Apply" and "OK" not to save lyrics.
(my life:) Maybe it would help if I told you how I use this plugin. In general, I don't display lyrics, but sometimes, I feel like I want to sing (sorry for that) so I open an OpenLyrics window for synchronised lyrics. I'll talk about the case I don't already have lyrics saved. In general, the autochoice is not a good one, that's why I don't want it autosaved. Then I search manually for good synchronised lyrics, and for that I need to compare several versions. But I don't want it to be saved yet. When I feel ready (I've made my choice), I right click on lyrics windows then "save lyrics". Hoping it helps understanding my motivation.
This is why the lyric search window has a preview, what is it that you're looking at on each lyric that the preview does not provide?
I can take a look but the "should we save" logic has in the past proven to be a bit fiddly (although maybe I was just being silly at the time).
I see... Funny how we see things differently ! The preview you mention (on the right) is just the first part in my case. I need to test this preview in Lyrics panel. Only then, I can see if it's well synchronised or if I need to test another preview. And occasionally, all previews are bad so I close the "searching Lyrics" window, hoping nothing will be saved.
Can you replace the "Apply" button with a "Test" Button then ? Since I was the one who asked for a "apply" button, but by that I meant a button who does not close window and does NOT save anything. Or you can add a "Test" button instead of replacing "Apply".
And just to be clear, it's not a new behavior I'm asking. It was present in all previous/old lyrics panels, even in previous version of this component.
I guess it comes down to how you interpret the "auto" bit of "autosave". If I recall correctly the current behaviour exists because the manual search window is open because you specifically asked for lyrics, as opposed to the automatic search that runs when you start playing a track (regardless of whether you wanted lyrics or not).
If I understand you correctly, this would be resolved by making the manual search respect the "autosave" config. I'd have to think through potential consequences but at face value that sounds reasonable.
