foo_openlyrics icon indicating copy to clipboard operation
foo_openlyrics copied to clipboard

Reset capitalisation: exclude the I

Open bservet opened this issue 4 years ago • 2 comments

It would be nice if the reset capitalisation would leave the letter I alone in these cases:

with a space in front and after the I with an apostrophe after the I

without this a sentence like: I'LL DO THIS becomes i'll do this and I HAVE TO KNOW becomes i have to know

And vice versa it could correct Maybe i'll do this to Maybe I'll do this.

Making this optional in a preference would to prevent this becoming a problem for non English lyrics.

thanks!

bservet avatar Dec 08 '21 10:12 bservet

I was going to suggest the same. Ideally it would allow us to add custom replacements (preferably with regex) so you'd just search for i and replace it with I (the spaces around being important). If that's a long shot, some sensible defaults (including said I) would be nice.

kamenminkov avatar Dec 18 '21 14:12 kamenminkov

I'm hesitant to add this because as you say it is specific to English lyrics and could be a slippery slope where we progressively are encouraged to individually support more and more cases (for this or other auto-edits).

The auto-edits are intended as a basic way to reduce the effort of fixing the obvious issues that lyrics sometimes have. They're not trying to replace manual edits.

Another concern is configurability. Yes we can always add an option to turn this off but the proliferation of options is also a problem I'd like to avoid and there are many other aspects of OpenLyrics that have (I think) a stronger case for configurability.

jacquesh avatar Jan 19 '22 18:01 jacquesh