jacquesh
Skip saving lrc lyrics that only contain one line
Would it be possible to add an option that automatically searched time stamped lyrics that contain only one line are not saved (skipped)?
Because there are many lyrics for my songs that are found and saved even though they only contain one line, like
[00:00.00] 作曲 : Linus Munch
This lrc was found for the Song Fed Rock by Island of Love.
I would rather hot have such incomplete lyrics to be saved because maybe when I listen to the song next time in some months, a complete lyric would be available and downloaded automatically then.
The proposed option Skip single line lrc option could be placed to the Saving page of the preferences.
That should be an optional exception. I wouldn't be surprised if users wrongly tag songs as instrumental. I already use filter format $if([%language%],,skip) to skip searches when there's no language tag.
"Single line" lyrics appear with newline; Now that is actually an improvement suggestion in itself, if there is only one line then you can spot in file properties that it actually does end, but if there is one line + CR LF it will show __ and you have to click to find that nope, that was it.
As for those like the OP suggests, where the "lyrics" only show composer and/or lyricist that way, and there are a whole lot of such in the Chinese-language sources: It could be dealt with by a setting that ignores lyrics with patterns like
- Timestamped lyrics with only [00:00.00] lines
- Non-timestamped lyrics on the following form: Every line is
In both cases, the test for a match should likely remove whitespace characters and empty (after whitespace removal) lines. I mean, not "removed" when the lyrics are tagged in, but for the purpose of testing for a match for removal.
Non-timestamped lyrics on the following form: Every line is
Huh. text surrounded by square brackets.
Duplicate: https://github.com/jacquesh/foo_openlyrics/issues/301
As I later discovered, filtering by line count wouldn't be sufficient here, many of those have other metadata lines.
I also noticed one thing here
Those Chinese characters that appear are only from those source that the plugin searches automatically from. It even comes for tracks with lyrics. So I tried the search manually command and selected the source called "LRCLIB" which didn't have any of those Chinese characters.
From the above image the track (A lofi song) doesn't have lyrics and indeed doesn't have any lyrics from "LRCLIB" but the net ease ones do.
So maybe change the automatic search source precedence?
I actually prefer to download my lyrics from LRCLIB cause it is just better (and open source) so I do hope if there is a way to change the automatic search source order our self in settings.
I think this should be done in a source-specific way such that each source filters out its own placeholder lyrics. We already do this for some sources but I know netease still needs to be handled, and that's covered by #423.
I'm going to close this and say we need source-specific tickets for solving this in the cases where sources other than netease do the same thing.
