LinqFaster icon indicating copy to clipboard operation
LinqFaster copied to clipboard

[Enhancement] Should these API's be marked with the [Pure] attribute

Open Smurf-IV opened this issue 6 years ago • 2 comments

TLDR: Indicates that a type or method is pure, that is, it does not make any visible state changes.

See https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.contracts.pureattribute?view=netframework-4.8

Smurf-IV avatar Aug 02 '19 14:08 Smurf-IV

For any that do not take a delegate, this would be okay. Those that do though have their purity implicit on the purity of the delegate, so would need to be omitted. Do you want to send a PR adding it, Smurf?

ndrwrbgs avatar Aug 10 '19 18:08 ndrwrbgs

I've been trying to set-up seperate PR's but they keep being merged into the single outstanding one, so I gave up, and just Commented each with a relevant comment. I'll wait until the Existing PR "Goes away"

Smurf-IV avatar Aug 12 '19 06:08 Smurf-IV