Checka11y.css icon indicating copy to clipboard operation
Checka11y.css copied to clipboard

Important comment is repeated thrice in main checka11y.css file

Open jackdomleo7 opened this issue 4 years ago • 6 comments

Details

The below comment should only appear in the checka11y.css file once, but it appears 3 times. (NOTE: Version may be different to the time this was raised)

/*! Checka11y.css v1.3.3 | MIT License | github.com/jackdomleo7/Checka11y.css */

Screenshot(s)

N/A

What is Expected?

Important comment to only appear once in checka11y.css.

What is actually happening?

Important comment is appearing 3 times in checka11y.css.

jackdomleo7 avatar Oct 09 '21 20:10 jackdomleo7

Can i be asigned this for an outreachy contribution. Thanks

caseynv avatar Oct 10 '21 01:10 caseynv

Since caseynv was here first, they deserve first dibs. Otherwise, if this becomes stale, I'm happy to be the "fallback" assignee!

tannerdolby avatar Oct 10 '21 02:10 tannerdolby

Of course @caseynv ! Thank you.

jackdomleo7 avatar Oct 10 '21 07:10 jackdomleo7

Just an FYI - there is a new bug relating to this so I will log it here:

With the release of v2, we have noticed that not only is /*! Checka11y.css v2.0.0 | MIT License | github.com/jackdomleo7/Checka11y.css */ appearing thrice, it now appears at random points in the CSS files and no longer appears at the top either.

We noticed this in @tannerdolby's PR (#124).

jackdomleo7 avatar Oct 20 '21 08:10 jackdomleo7

Hi @caseynv, have you made any progress on this? If not, since it has been inactive for 3 months, it'll have to be unassigned and available for someone else to pick up (maybe @tannerdolby if he's still interested).

jackdomleo7 avatar Jan 17 '22 19:01 jackdomleo7

👋 @jackdomleo7

Depending on @caseynv's response, I'm happy to take this on. It bugged me quite a bit that I couldn't find the issue when we first discussed it awhile back, so I'm eager to get to the bottom of the problem.

tannerdolby avatar Jan 18 '22 01:01 tannerdolby

Hey! Can I be assigned to this issue?

Mohit-Aasirwal avatar Sep 26 '22 17:09 Mohit-Aasirwal

Hi @Mohit-Aasirwal, sure, thank you!

jackdomleo7 avatar Sep 27 '22 11:09 jackdomleo7

Hey @Mohit-Aasirwal, did you get anywhere with this?

jackdomleo7 avatar Jan 19 '23 10:01 jackdomleo7

@jackdomleo7 👋 If no one responds or is assigned soon, I've got some free time this weekend to track down a fix for this. Hope you've been well mate!

tannerdolby avatar Jan 19 '23 16:01 tannerdolby

@tannerdolby Absolutely! Considering we've not heard back from @Mohit-Aasirwal in 4 months, I'd be happy to assign it to you 🙂

jackdomleo7 avatar Jan 19 '23 19:01 jackdomleo7

@jackdomleo7 Cool! Thanks :) You will probably laugh when you see the fix but the comment appearing thrice was expected based on the order of compiling for the partial files in checka11y.scss. I submitted a fix and now the comment only appears once at the top of checka11y.css.

tannerdolby avatar Jan 20 '23 05:01 tannerdolby