sdk icon indicating copy to clipboard operation
sdk copied to clipboard

Previews for matparams

Open neph1 opened this issue 3 years ago • 3 comments

This is both preview of shader node outputs, editing them and some general refactoring and fixes made along the way.

I'm afraid this is going to be a big one, so I'm creating a draft in case anyone wants to tag along :)

Edit: I'm unsure as to why it replaces some whole files. Because line endings were wrong?

neph1 avatar May 16 '22 20:05 neph1

This PR adds both previews and editors for values for the shader nodes. I'd still like to explore it a bit further and see if i can pass down MatParams all the way to the nodes, that would make some things easier to formalize.

neph1 avatar May 20 '22 14:05 neph1

I tried breaking out the live updates for materials into its own, but it's too nestled in with the rest.

neph1 avatar May 25 '22 19:05 neph1

Getting there... This last merge was really messy. Cause: Line endings updated on other PR's but not this one. One more "lesser" pr to go before i'll finish this one up.

neph1 avatar Jun 07 '22 20:06 neph1

Note to self: Still line ending issue with MatDefNode https://github.com/jMonkeyEngine/sdk/pull/334/files#diff-8a908aef5dc64b9e3bf08da756c62262ce21cc6bc19307bce81d0261cf22ca58

neph1 avatar Aug 23 '22 12:08 neph1

I think this PR deserves a squash commit. I'll request an inverse review; Unless someone complains loudly, I'll merge this in a couple of days time.

neph1 avatar Aug 25 '22 19:08 neph1