orbitkit icon indicating copy to clipboard operation
orbitkit copied to clipboard

feat: upgrade to bun

Open imCorfitz opened this issue 1 year ago • 2 comments

Thanks to the version 1.1.9 release of Bun, a lot of workspace issues have been resolved, and we are now one step closer to getting bun for Orbitkit.

Fixes #50

To install a dependency to a specific package use --cwd e.g.: bun add --cwd apps/web sharp

To do:

  • [x] Update CONTRIBUTING.md
  • [x] Update Documentation
  • [x] Update Github Workflows
  • [x] Update Playwright configs
  • [x] Update Husky
  • [ ] Find alternative to @commitlint/config-pnpm-scopes
  • [x] Create alternative to pnpm recursive exec -- pnpm version 0.1.0

Known issues:

  • No support for Volta

imCorfitz avatar May 22 '24 10:05 imCorfitz

🦋 Changeset detected

Latest commit: 05730732a0af9213920f9da33adca283381ec490

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@orbitkit/marketing Minor
@orbitkit/storybook Minor
@orbitkit/tailwind Minor
@orbitkit/tsconfig Minor
eslint-config-orbitkit Minor
@orbitkit/vite Minor
@orbitkit/assets Minor
@orbitkit/utils Minor
@orbitkit/auth Minor
@orbitkit/core Minor
@orbitkit/api Minor
@orbitkit/env Minor
@orbitkit/db Minor
@orbitkit/ui Minor
@orbitkit/docs Minor
@orbitkit/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar May 22 '24 10:05 changeset-bot[bot]

@ixahmedxi - Should we remove Volta from Orbitkit, as bun isn't currently supported?

imCorfitz avatar May 24 '24 14:05 imCorfitz

@imCorfitz Yes that is correct, with the usage of bun, we shouldn't need volta at all.

ixahmedxi avatar May 25 '24 16:05 ixahmedxi

Regarding the commitlint scopes, we got two options:

  1. Remove the package: Allowing any scope to be written when committing changes.
  2. Write a proprietary getProjects function in a .commitlintrc file.

What do we prefer?

imCorfitz avatar May 25 '24 16:05 imCorfitz

It looks all good to me, just one lil thing left to do which is to add a changeset to the PR. Also don't forget to update the version in the root package.json because changeset doesn't do that automatically

ixahmedxi avatar May 27 '24 13:05 ixahmedxi

Would you consider this a patch or minor version update?

imCorfitz avatar May 27 '24 13:05 imCorfitz

@imCorfitz I think it's a minor

ixahmedxi avatar May 27 '24 14:05 ixahmedxi

With the eslint v9 stuff coming in, would make sense to start a 0.2 version upgrade

ixahmedxi avatar May 27 '24 14:05 ixahmedxi

That's what I thought.. Will update the changesets quickly.

imCorfitz avatar May 27 '24 14:05 imCorfitz